Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change peerDependencies versions #15

Merged
merged 25 commits into from
Mar 13, 2018
Merged

Conversation

A-gambit
Copy link
Member

No description provided.

@A-gambit A-gambit changed the title change deps Change peerDependencies versions Sep 14, 2017
@blacktaxi
Copy link
Member

Looks like we need to wait for @types/react-dom to receive an update – currently it comes with its own dependency of @types/react@15.0.38 which conflicts with our local @types/react@16.0.7.

@blacktaxi blacktaxi mentioned this pull request Sep 26, 2017
@oleksiilevzhynskyi
Copy link
Collaborator

@blacktaxi @A-gambit react-dom already in sync with react, so we can update it.

Also, let's update rxjs up to 5.5.6. Changes from 4.5.3...5.5.6 contain fixes to bunch of issues when errors in subscribe were silently swallowed.

@oleksiilevzhynskyi
Copy link
Collaborator

Looks like there is an issue with the 15.x version that causes typing issues - https://goo.gl/prc6Mq. @types/react-dom@15.5.1 has a dependency to @types.react* that resolves to @types.react@16.0.3 even so, there is @types/react@15.0.38 in package.json.
It can be fixed by "resolutions" key in package.json

"resolutions": {
 "@types/react": "15.0.38"
}

But, in that case, 16.x version would be broken.

@blacktaxi Do we really need to support 15.x version?

@blacktaxi blacktaxi merged commit 9d1871b into master Mar 13, 2018
@blacktaxi blacktaxi deleted the update-peer-dependencies branch March 13, 2018 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants