Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements #6

Merged
merged 9 commits into from
Apr 4, 2024
Merged

Minor improvements #6

merged 9 commits into from
Apr 4, 2024

Conversation

roziscoding
Copy link
Contributor

@roziscoding roziscoding commented Mar 27, 2024

  • feat: remove ts-pattern dependency
  • feat: create InvalidScope error
  • feat: await Promise.all insite setMyCommands
  • docs: add docstring to commands function
  • docs: add docstring to getNearestCommand
  • feat: make setMyCommands return Promise
  • refactor: make CommandsFlavor an interface
  • chore: bump npm version

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 39 lines in your changes are missing coverage. Please review.

Project coverage is 67.25%. Comparing base (45be98a) to head (4a007e7).

Files Patch % Lines
src/command.ts 21.42% 33 Missing ⚠️
src/errors.ts 33.33% 4 Missing ⚠️
src/context.ts 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
- Coverage   69.62%   67.25%   -2.38%     
==========================================
  Files           6        7       +1     
  Lines         405      400       -5     
  Branches       47       52       +5     
==========================================
- Hits          282      269      -13     
- Misses        123      131       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KnorpelSenf
Copy link
Member

26o9hx46zr981

@roziscoding
Copy link
Contributor Author

26o9hx46zr981

No approve tho 😔

@KnorpelSenf
Copy link
Member

Correct. It would take a while to review this. You can merge without approval if you don't feel like waiting.

@roziscoding roziscoding merged commit 0f2a239 into main Apr 4, 2024
8 checks passed
@roziscoding roziscoding deleted the new-context-interface branch April 4, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants