Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More DateCalculator Improvements #636

Conversation

stevenyoungs
Copy link
Contributor

@emyoulation made some comments on PR #632 after merge, which are addressed in this PR.
See his comment here

  1. Increase the precision of span results so that all values are shown in DateCalculator
    By default gramps only shows the 2 most significant values from (years, months, days). For a date calculator it seems more appropriate to show all 3. Zero values are omitted from the result string
  2. format the registration file, bump the version and update authors
  3. Increase the default height of the gramplet so that all controls are visible when the gramplet is detached

When both expressions are a date, the result is a span.
By default spans are converted to  string with only the two most signficant units displayed out of (years, months, days).
For DateCalculator, maximum precision is more appropriate so use precision 3.
This allows all controls to be visible when the gramplet is detached
@GaryGriffin
Copy link
Member

Since the gramps60 addon branch now exists, can you create a second PR for that branch. Normally I would just cherry-pick, but you have rewritten the GPR file and I cannot push that to the gramps60 branch since it is for the gramps52 branch.

@emyoulation
Copy link
Contributor

Can the whole 5.2 set be pushed to the 6.0 branch?

Perhaps also have a dumbed-down (version blind) version of the make.py generate the old-style
addons-en CSV? Such a CSV file could be easily be imported into a spreadsheet for use as a checklist.

It could show which need revisions for:

  1. re-targeting Gramps version
  2. need a description improvement
  3. need a help_url
  4. need an author/maintainer

(Such a CSV list would be useful for a checklist of the built-in plug-ins too.)

@Nick-Hall
Copy link
Member

Can the whole 5.2 set be pushed to the 6.0 branch?

The gramps60 branch contains everything in the gramps52 branch. All addons have also been rebuilt for v6.0.

@stevenyoungs
Copy link
Contributor Author

Since the gramps60 addon branch now exists, can you create a second PR for that branch. Normally I would just cherry-pick, but you have rewritten the GPR file and I cannot push that to the gramps60 branch since it is for the gramps52 branch.

@GaryGriffin please see PR #637

@GaryGriffin GaryGriffin merged commit d18ce73 into gramps-project:maintenance/gramps52 Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants