-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor, fix, and optimizer filters/rules #1794
base: master
Are you sure you want to change the base?
Conversation
This reverts commit a9da731.
For many attributes of an object, it isn't so much "internal" now that we are switching to JSON. For example, this is the Person object API to get the parent family list: person.parent_family_list # object attribute
person.get_parent_family_handle_list() # function call With the above person.parent_family_list # JSON access
person.get_parent_family_handle_list() # function call, instantiates object The new version would hide the fact that the function call creates the object (but just once). So because the JSON data mirrors the actual attribute names, it doesn't have to change at all. |
Created a PR #1824 to explore attribute access of the JSON dict. |
I'll update this PR to use new DataDict attribute access to dict. Which will actually revert most of the data access to what it is in master. |
@Nick-Hall, I want to refactor this PR based on the DataDict from #1824. Should I change the base branch to #1824, or wait until it is merged? |
I have reviewed and merged PR #1824. Normally we would wait longer to give people longer to comment, but in this case the PR was related to existing work so I made an exception. |
Thank you! |
This PR does three things: