Optimize hexadecimal conversions in serde_utils to speed up JSON serialization of byte collections #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generalize some code in eth2_cache_utils and benches to work on collections containing any type.
…alization of byte collections Slow serialization to JSON was claimed to be the problem that led to 2e92e00. BlobSidecar serialization is now around 15.4 times faster. BlobSidecar deserialization is now around 12 times faster. SignedBeaconBlock serialization is now up to 1.5 times faster. SignedBeaconBlock deserialization is now up to 1.1 times faster. faster-hex might be faster than const-hex in some cases, but faster-hex does not provide the API we require. See https://crates.io/crates/const-hex/1.14.0 for benchmark results comparing various hexadecimal conversion crates.
|
|
Tumas
reviewed
Jan 10, 2025
| @@ -339,7 +340,6 @@ hash_hasher = '2' | |||
| hashlink = '0.9' | |||
| hex = { version = '0.4', features = ['serde'] } | |||
There was a problem hiding this comment.
thought: const-hex claims to be a drop-in replacement for the hex crate, maybe we should drop hex and switch to const-hex for the rest of the app? Though this might be out of scope for this MR.
Tumas
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commit messages for details.