Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code scanning alert no. 18: User-controlled bypass of sensitive method #505

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

KrzysztofPajak
Copy link
Member

Fixes https://github.com/grandnode/grandnode2/security/code-scanning/18

To fix the problem, we need to ensure that the authorization check is performed regardless of whether the model parameter is null or not. This can be achieved by rearranging the code so that the authorization check is done before the null check. This way, even if the model is null, the authorization check will still be executed.

  • Move the authorization check _permissionService.Authorize(PermissionSystemName.Products) before the null check for the model parameter.
  • Ensure that the authorization check is the first condition to be evaluated in the method.

Suggested fixes powered by Copilot Autofix. Review carefully before merging.

…ethod

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant