Fix code scanning alert no. 18: User-controlled bypass of sensitive method #505
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/grandnode/grandnode2/security/code-scanning/18
To fix the problem, we need to ensure that the authorization check is performed regardless of whether the
model
parameter is null or not. This can be achieved by rearranging the code so that the authorization check is done before the null check. This way, even if themodel
is null, the authorization check will still be executed._permissionService.Authorize(PermissionSystemName.Products)
before the null check for themodel
parameter.Suggested fixes powered by Copilot Autofix. Review carefully before merging.