Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review all duration spells for error messages and expiration checks #136

Open
grannypron opened this issue Jan 16, 2021 · 6 comments
Open
Assignees
Labels
bug Something isn't working game39 Next

Comments

@grannypron
Copy link
Owner

  1. Make a list of all spells in the game that the characters can / should be able to learn.
  2. Check them for errors when executing [SpellDuration] if that hook is specified in the specialAbilities database
  3. Remove the [SpellDuration] hook if necessary and add expiration mechanic as per Protection From Evil / Prayer fix - see Error when casting Protection from Evil #102 and Prayer spell never wears off #75
@grannypron
Copy link
Owner Author

grannypron commented Jan 17, 2021

After a brief review, these are the ones that I think may have SAs attached to them that we need to check:

Cleric:

Bless
Curse
Detect Magic
Protection from Evil
Protection from Good
Resist Cold

Find Traps
Resist Fire
Silence 15' Radius

Cause Blindness
Cause Disease
Prayer
Bestow Curse

MU:

Detect Magic
Enlarge
Reduce
Friends
Protection from Evil
Protection from Good
Read Magic
Shield

Detect Invisibility
Invisibility
Mirror Image
Ray of Enfeeblement
Strength

Blink
Haste
Hold Person
Invisibility, 10' Radius
Protection From Evil, 10' Radius
Protection From Good, 10' Radius
Protection from Normal Missiles
Slow

@grannypron
Copy link
Owner Author

These spells have already been handled: Enlarge, Reduce, and Prayer.

@grannypron
Copy link
Owner Author

grannypron commented Jan 25, 2021

I have also checked the following: Bless, Curse, Detect Magic (Cleric), Protection from Evil (Cleric), Protection from Good(Cleric), Resist Cold, Resist Fire, Hold Person, and Find Traps.

Cause Blindness & Bestow Curse are permanent (until dispelled).

@grannypron grannypron self-assigned this Jan 25, 2021
@grannypron
Copy link
Owner Author

I have checked duration on all Cleric spells so far.

@grannypron
Copy link
Owner Author

grannypron commented Jan 30, 2021

Mage spells done: Detect Magic, Enlarge, Reduce, Protection From Evil, Shield, Strength, Invisibility, Invisibility 10' Radius, Protection from Evil 10' Radius, Protection from Good 10' Radius, Protection from Normal Missiles, Blink.

@grannypron
Copy link
Owner Author

Slow, Mirror Image, and Ray of Enfeeblement are left

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working game39 Next
Projects
None yet
Development

No branches or pull requests

1 participant