-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't squeeze hanging comments to the left #20
Comments
Here's what black does for long arg lists:
to
|
It would be nice to preserve the column of the original comment. |
+1'ing again after formatting grantjenks/python-diskcache. Hanging comments are necessary and the jagged pattern hurts my eyes. |
warsaw
added a commit
that referenced
this issue
Jan 23, 2021
We're close but not quite there yet! ``` error: cannot format /tmp/bar.py: INTERNAL ERROR: Black produced different code on the second pass of the formatter. Please report a bug on https://github.com/psf/black/issues. This diff might be helpful: /var/folders/dg/2gcv7qh1141dfc13k7kbty7w000slb/T/blk_81rqaiyh.log Oh no! 💥 💔 💥 1 file would fail to reformat. ``` Closes #20
warsaw
added a commit
that referenced
this issue
Jan 27, 2021
Preserve whitespace before hash mark on hanging comments Closes #20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Let's consider not squeezing hanging comments to the left, e.g. not doing this:
And here's an egregious example from flufl.i18n:
The latter is definitely less readable.
The text was updated successfully, but these errors were encountered: