Bug fix: Fix peek when value is so large that a file is used (#288)

Error caused by copy/paste from pull().
grantjenks · Aug 31, 2023 · 17a5f42 · 17a5f42
1 parent 4d30686
commit 17a5f42
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/diskcache/core.py b/diskcache/core.py
@@ -1703,9 +1703,6 @@ def peek(
             except IOError:
                 # Key was deleted before we could retrieve result.
                 continue
-            finally:
-                if name is not None:
-                    self._disk.remove(name)
             break
 
         if expire_time and tag:

diff --git a/tests/test_deque.py b/tests/test_deque.py
@@ -302,3 +302,13 @@ def test_rotate_indexerror_negative(deque):
 
     with mock.patch.object(deque, '_cache', cache):
         deque.rotate(-1)
+
+
+def test_peek(deque):
+    value = b'x' * 100_000
+    deque.append(value)
+    assert len(deque) == 1
+    assert deque.peek() == value
+    assert len(deque) == 1
+    assert deque.peek() == value
+    assert len(deque) == 1