add SortedArray #183
Open
add SortedArray #183
+179
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It’s reasonable except for the lack of array.array.sort. Can you get support for that upstream? I haven’t searched bugs.python.org but it’s worth researching. |
Looks more like PEP rather than a bug to me. I found none. Is it a good one to request? Before the array.sort() becomes a thing, we can try RADIX sort in pure Python, O(N) memory, O(N) time. |
ilemhadri
reviewed
Oct 5, 2022
ilemhadri
reviewed
Oct 5, 2022
fix docstrings Co-authored-by: ilemhadri <19997801+ilemhadri@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for a sorted container based off the standard library array.array class.
Enables compact storage of numerical values saving times fold in memory required.
Time performance is en par with the List based implementation below 1M size, and marginally better at 10M and 100M size,
as tested on M1 Max 64GB RAM