Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modelsummary 1.4.0 #31

Merged

Conversation

vincentarelbundock
Copy link
Contributor

kableExtra does not appear to be actively maintained and it causes some problems on pkgdown websites and for installation on some platforms. In version 1.4.0, modelsummary will no longer depend on kableExtra. Instead it will give the user a choice to install any of the supported table-making package, and offer a function to set a persistent default.

Call setting:

modelsummary(model, output = "gt")

Persistent setting stays only for the current session:

options(modelsummary_factory_default = "gt")

Persistent setting stays across sessions:

config_modelsummary(factory_default = "gt")

Developers of packages that use modelsummary in vignettes need to add a table-making package to Suggests.

@grantmcdermott
Copy link
Owner

Thanks mate, appreciate the HU. I'll hold off on this for now until 1.4.0 hits CRAN. (Or does this this gt-based functionality already work well with the current CRAN version?)

@vincentarelbundock
Copy link
Contributor Author

Yes, in principle this PR should be safe and work with past, present, and future versions of ˋmodelsummary‘.

@grantmcdermott grantmcdermott merged commit 7aa1aa7 into grantmcdermott:main Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants