-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dedicated plot.parttree method #18
Open
grantmcdermott
wants to merge
25
commits into
main
Choose a base branch
from
tinyplot
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also warn user if orginal data cannot be retrieved
- ploting the dummy object first with a formula ensures correct axes and legend titles whilst still allowing for customization via ...
- Also, better catch for mlr3 objects
Hmmm. Workflows are failing due missing ggplot2 installation. But the log file shows that it has been installed. https://github.com/grantmcdermott/parttree/actions/runs/10102909981/job/27939351692?pr=18#step:5:4882 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14.
Closes #16.
Addresses #9 (even if it doesn't provide a formal fix).
This PR introduces a formal
"parttree"
class and provides a nativeplot.parttree
method using base R graphics (powered by tinyplot). The ggplot2 scaffolding is still supported viageom_parttree()
.Example from the new README:
Created on 2024-07-25 with reprex v2.1.0
It includes several smaller changes at the same time, e.g.
flipaxes
is renamed toflip
.