Refactor data set registration #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #44 +/- ##
========================================
- Coverage 1.24% 1.23% -0.01%
========================================
Files 18 19 +1
Lines 2898 2908 +10
========================================
Hits 36 36
- Misses 2862 2872 +10
☔ View full report in Codecov by Sentry. |
grantmerz
requested changes
Oct 24, 2023
There was a problem hiding this comment.
Looks good except I would like to have the function in DatasetCatalog.register be an argument that the user can supply rather than set to get_data_from_json (although that can be a default argument). This is because data might be in different enough formats that I would like the user to be able to supply a custom function (see Issue #33)
|
Sounds good. I added it that option. |
grantmerz
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaks data set registration into a function to reduce duplicate code. Also adds a check on the file's existence.