New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create ImageReader subclasses #53

Merged

jeremykubica merged 2 commits into main from refactor

Oct 30, 2023

jeremykubica commented Oct 30, 2023

Create specialized subclasses of ImageReader so that we do not need to pass in functions to read the data (they are instead part of the subclass).

Add tests for the HSCImageReader and DC2ImageReader.

jeremykubica added 2 commits

October 30, 2023 15:41


          Alternate organization

2bfd388


          Add tests

95a3a85

jeremykubica requested a review from grantmerz

October 30, 2023 19:56

grantmerz approved these changes

View reviewed changes

Owner

grantmerz left a comment

This is a nice way to do it. Maybe something similar for the key_mapper functions would be useful?

jeremykubica merged commit bedefa9 into main

1 of 3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet