Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commenting out automatic pylint checks #63

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

drewoldag
Copy link
Collaborator

I've commented out the pylint checks, because right now they aren't helping, and we don't currently have time to address the errors being reported.

I've also moved the lint.yml file out of the .github/workflows directory into .github. It won't run automatically, but when we're ready to reintroduce pylint checks, we can simply move it back to the workflows directory, and uncomment the pylint checks in .pre-commit.yaml.

@drewoldag drewoldag self-assigned this Nov 16, 2023
@drewoldag drewoldag requested a review from grantmerz November 16, 2023 22:36
@drewoldag drewoldag linked an issue Nov 16, 2023 that may be closed by this pull request
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 166 lines in your changes are missing coverage. Please review.

Comparison is base (a8888a1) 7.77% compared to head (7246279) 7.77%.
Report is 3 commits behind head on main.

Files Patch % Lines
src/deepdisc/model/models.py 0.00% 102 Missing ⚠️
src/deepdisc/inference/match_objects.py 0.00% 58 Missing ⚠️
src/deepdisc/inference/predictors.py 0.00% 4 Missing ⚠️
src/deepdisc/model/loaders.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main     #63   +/-   ##
=====================================
  Coverage   7.77%   7.77%           
=====================================
  Files         19      19           
  Lines       3265    3265           
=====================================
  Hits         254     254           
  Misses      3011    3011           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drewoldag drewoldag merged commit 7205c51 into main Nov 16, 2023
3 of 4 checks passed
@drewoldag drewoldag deleted the issue/62/comment-out-pylint branch November 16, 2023 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comment out pylint
2 participants