Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configs follow up #66

Merged
merged 25 commits into from
Dec 12, 2023
Merged

Configs follow up #66

merged 25 commits into from
Dec 12, 2023

Conversation

OliviaLynn
Copy link

@OliviaLynn OliviaLynn commented Nov 21, 2023

For #16

Items in this PR:

  • Add config files for other two modnames mvitv2 and vitdet
  • Updating var names and docstrings where cfg_loader is used; removing cfg_loader usage in predictors.py, loaders.py, trainers.py
  • AstroPredictor (in astrodet.py) handled two cases: where the user has only yacs-style configs, and where they have both yacs and Lazy. The constructor is only called in the test/train scripts and demo_hsc notebook (and only demo_hsc reaches the removed yacs-only branch--which will be taken care of in the next PR)
  • Implemented "solo" versions of test_run_transformers, test_run_transformers_DC2, andtest_run_transformers_DC2_redshift. Need to add versions of:

For convenience, commands that run the solo scripts:

python solo_run_scripts/solo_test_run_transformers.py
python solo_run_scripts/solo_test_run_transformers.py --modname mvitv2 --run-name mvitv2_test
python solo_run_scripts/solo_test_run_transformers_DC2.py --data-dir ./tests/deepdisc/test_data/dc2/
python solo_run_scripts/solo_test_run_transformers_DC2.py --data-dir ./tests/deepdisc/test_data/dc2/ --modname mvitv2 --run-name mvitv2_test
python solo_run_scripts/solo_test_run_transformers_DC2_redshift.py --data-dir ./tests/deepdisc/test_data/dc2/
python solo_run_scripts/solo_test_run_transformers_DC2_redshift.py --data-dir ./tests/deepdisc/test_data/dc2/ --modname mvitv2 --run-name mvitv2_test

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (a8888a1) 7.77% compared to head (7948791) 12.86%.
Report is 47 commits behind head on main.

Files Patch % Lines
src/deepdisc/astrodet/astrodet.py 0.00% 10 Missing ⚠️
src/deepdisc/training/trainers.py 0.00% 4 Missing ⚠️
src/deepdisc/inference/predictors.py 0.00% 2 Missing ⚠️
src/deepdisc/model/loaders.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##            main      #66      +/-   ##
=========================================
+ Coverage   7.77%   12.86%   +5.08%     
=========================================
  Files         19       22       +3     
  Lines       3265     3451     +186     
=========================================
+ Hits         254      444     +190     
+ Misses      3011     3007       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OliviaLynn OliviaLynn changed the title WIP - configs follow up Configs follow up Dec 6, 2023
@OliviaLynn OliviaLynn marked this pull request as ready for review December 6, 2023 15:42
solo_run_scripts/solo_test_eval_model.py Outdated Show resolved Hide resolved
solo_run_scripts/solo_test_eval_model.py Outdated Show resolved Hide resolved
solo_run_scripts/solo_test_eval_model.py Outdated Show resolved Hide resolved
solo_run_scripts/solo_test_eval_model.py Outdated Show resolved Hide resolved
solo_run_scripts/solo_test_eval_model.py Outdated Show resolved Hide resolved
solo_run_scripts/solo_test_eval_model.py Outdated Show resolved Hide resolved
@OliviaLynn OliviaLynn merged commit bc66b32 into main Dec 12, 2023
3 of 4 checks passed
@OliviaLynn OliviaLynn deleted the issue/16/configs branch December 13, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants