forked from burke86/deepdisc
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configs follow up #66
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #66 +/- ##
=========================================
+ Coverage 7.77% 12.86% +5.08%
=========================================
Files 19 22 +3
Lines 3265 3451 +186
=========================================
+ Hits 254 444 +190
+ Misses 3011 3007 -4 ☔ View full report in Codecov by Sentry. |
jeremykubica
reviewed
Dec 7, 2023
jeremykubica
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #16
Items in this PR:
mvitv2
andvitdet
cfg_loader
is used; removing cfg_loader usage inpredictors.py
,loaders.py
,trainers.py
astrodet.py
) handled two cases: where the user has only yacs-style configs, and where they have both yacs and Lazy. The constructor is only called in the test/train scripts and demo_hsc notebook (and only demo_hsc reaches the removed yacs-only branch--which will be taken care of in the next PR)test_eval_model
(next-next PR/related to Code re-org: unify the train scripts #17)For convenience, commands that run the solo scripts: