Skip to content

Commit

Permalink
refactor: add tailwind (#7)
Browse files Browse the repository at this point in the history
* chore: update .gitignore

Add .env and cypress/downloads to list of ignored files.

* style: add prettier-plugin-tailwindcss

* feat: reset css styles

* chore: remove redundant import

* refactor: replace scss for home component with tailwind

* refactor: replace scss for login component with tailwind

* refactor: replace scss for cards component with tailwind

* refactor: replace scss for charts with tailwind

* refactor: move ref to  privacy policy to home component

* refactor: replace scss for app component with tailwind

* refactor: replace scss for flag component with tailwind

* chore: remove settings.json

* test: remove spec file for home component

* test: fix broken e2e test for privacy
  • Loading branch information
grantwforsythe authored May 6, 2024
1 parent 20dc028 commit 2c90b6c
Show file tree
Hide file tree
Showing 29 changed files with 176 additions and 534 deletions.
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -42,3 +42,6 @@ testem.log
# System files
.DS_Store
Thumbs.db

# Environment
.env
7 changes: 7 additions & 0 deletions .stylelintrc.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
{
"extends": ["stylelint-config-standard", "stylelint-config-standard-scss"],
"rules": {
"at-rule-no-unknown": null,
"scss/at-rule-no-unknown": [
true,
{
"ignoreAtRules": ["tailwind"]
}
],
"unit-allowed-list": ["em", "rem", "%", "s"]
}
}
3 changes: 0 additions & 3 deletions .vscode/settings.json

This file was deleted.

8 changes: 8 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,21 +1,28 @@
## Development

To get started, ensure both [Node v18.x or the latest LTS version](https://nodejs.org) and npm 8.x are installed, and then install the dependencies.

```bash
npm install
npm start
```

### Tech Stack

- Style - SCSS
- State Management - NgRx
- Frontend - Angular

## Testing

[Cypress](https://www.cypress.io/) is used for E2E tests.

```bash
npm run e2e
```

[Jasmine](https://jasmine.github.io/) and [Karma](https://karma-runner.github.io/6.4/index.html) are used for unit tests.

```bash
npm run test
```
Expand All @@ -31,4 +38,5 @@ npm run test
- Example: fix/bug-1

## Commit Message Format

All commit messages must adhere to the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) standard, which is enforced by [commitlint](https://commitlint.js.org/). (The styling of commit messages is enforced because the [CHANGELOG](https://github.com/grantwforsythe/custom-reports-for-ynab/blob/main/CHANGELOG.md) is autogenerated by [release-it](https://github.com/release-it/conventional-changelog).
2 changes: 1 addition & 1 deletion cypress/e2e/spec.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ describe('Custom Reports for YNAB', () => {
});

it('Should route to privacy page', () => {
cy.get('footer a').should('contain', 'Privacy Policy').click();
cy.get('p a').contains('privacy policy').click();
cy.location().should((location) => expect(location.pathname).to.eq('/privacy'));
cy.get('h1').should('contain', 'Privacy Policy');
cy.get('div.content a').should('have.attr', 'href', 'https://api.ynab.com/#terms');
Expand Down
Loading

0 comments on commit 2c90b6c

Please sign in to comment.