-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/add macros #9
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grantwforsythe
force-pushed
the
feat/add-macros
branch
from
September 19, 2024 02:38
6396872
to
a4ae9fd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9 +/- ##
==========================================
- Coverage 72.00% 70.29% -1.71%
==========================================
Files 11 14 +3
Lines 925 1111 +186
==========================================
+ Hits 666 781 +115
- Misses 225 288 +63
- Partials 34 42 +8
|
The current implmentation of Modify does not change the token type for the parent node which will cause issues when inspecting the string output of the node.
This was causing a nil pointer dereference error because 'macro!' is an invalid name so it wasn't getting assigned.
puts in a builtin function that will print the object to the console and return a null object.
grantwforsythe
force-pushed
the
feat/add-macros
branch
from
September 24, 2024 02:48
6209a39
to
91a84de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add (very buggy) macro system which utilizes three new key words:
Example