Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] Change various MRP labels #355

Conversation

quentinDupont
Copy link
Member

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7bbe5af) 78.51% compared to head (948af93) 78.51%.
Report is 21 commits behind head on 12.0.

Additional details and impacted files
@@           Coverage Diff           @@
##             12.0     #355   +/-   ##
=======================================
  Coverage   78.51%   78.51%           
=======================================
  Files         221      221           
  Lines        2486     2486           
  Branches      440      440           
=======================================
  Hits         1952     1952           
  Misses        502      502           
  Partials       32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 / 3 remarques non bloquantes. Sinon, ça a l'air good.
bise !

mrp_sale_grouped/models/mrp_sale_grouped.py Outdated Show resolved Hide resolved
mrp_business/views/view_mrp_bom.xml Outdated Show resolved Hide resolved
#. module: mrp_business
#: model:ir.model.fields,field_description:mrp_business.field_mrp_bom__diff_bom_qty_and_net_quantities
msgid "Diff Bom Qty And Net Quantities"
msgstr ""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c'est pas traduit. (en même temps, c'est pas un champ nouveau). peut-etre un oubli ?

quentinDupont and others added 3 commits January 25, 2024 15:58
Co-authored-by: Sylvain LE GAL <sylvain.legal@grap.coop>
Co-authored-by: Sylvain LE GAL <sylvain.legal@grap.coop>
Copy link
Member

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MeP du 28/01/2024

/ocabot merge minor

@github-grap-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-355-by-legalsylvain-bump-minor, awaiting test results.

@github-grap-bot github-grap-bot merged commit ac95db5 into grap:12.0 Feb 5, 2024
4 checks passed
@github-grap-bot
Copy link
Contributor

Congratulations, your PR was merged at 6a716fe. Thanks a lot for contributing to grap. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants