Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

16.0 mig fiscal_company_base #54

Merged
merged 3 commits into from
Aug 5, 2024
Merged

Conversation

legalsylvain
Copy link
Member

No description provided.

@github-grap-bot github-grap-bot added this to the 16.0 milestone Aug 2, 2024
@legalsylvain legalsylvain force-pushed the 16.0-mig-fiscal_company_base branch from bc994dc to 86db237 Compare August 4, 2024 10:19
@legalsylvain legalsylvain force-pushed the 16.0-mig-fiscal_company_base branch from 86db237 to dfba0a5 Compare August 4, 2024 10:31
@legalsylvain legalsylvain marked this pull request as ready for review August 4, 2024 10:32
Copy link

codecov bot commented Aug 4, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 13 lines in your changes missing coverage. Please review.

Please upload report for BASE (16.0@3bdf156). Learn more about missing BASE report.

Files Patch % Lines
...odels/fiscal_company_change_search_domain_mixin.py 65.71% 7 Missing and 5 partials ⚠️
fiscal_company_base/models/res_company.py 97.36% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             16.0      #54   +/-   ##
=======================================
  Coverage        ?   92.85%           
=======================================
  Files           ?        9           
  Lines           ?      182           
  Branches        ?       42           
=======================================
  Hits            ?      169           
  Misses          ?        7           
  Partials        ?        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grap grap deleted a comment from github-grap-bot Aug 4, 2024
@legalsylvain
Copy link
Member Author

/ocabot migration fiscal_company_base

@github-grap-bot github-grap-bot mentioned this pull request Aug 4, 2024
1 task
@grap grap deleted a comment from github-grap-bot Aug 4, 2024
@legalsylvain legalsylvain changed the title 16.0 mig fiscal company base 16.0 mig fiscal_company_base Aug 4, 2024
@legalsylvain legalsylvain force-pushed the 16.0-mig-fiscal_company_base branch 3 times, most recently from 47b8b93 to a388dbc Compare August 4, 2024 21:06
@legalsylvain
Copy link
Member Author

/ocabot merge nobump

@github-grap-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-54-by-legalsylvain-bump-nobump, awaiting test results.

github-grap-bot added a commit that referenced this pull request Aug 4, 2024
Signed-off-by legalsylvain
- full refactor of code.
- create a dedicated OCA/multi-company module 'res_company_access_all_childs' to isolate code.
- refactor mixin. merge 'fiscal.child.check.mixin' and 'fiscal.mother.check.mixin'
- Add test for mixin models
@legalsylvain legalsylvain force-pushed the 16.0-mig-fiscal_company_base branch from a388dbc to f0fa380 Compare August 5, 2024 11:44
@legalsylvain
Copy link
Member Author

/ocabot merge nobump

@github-grap-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-54-by-legalsylvain-bump-nobump, awaiting test results.

@github-grap-bot github-grap-bot merged commit 9ca8c71 into 16.0 Aug 5, 2024
2 checks passed
@github-grap-bot
Copy link
Contributor

Congratulations, your PR was merged at 34221ff. Thanks a lot for contributing to grap. ❤️

@github-grap-bot github-grap-bot deleted the 16.0-mig-fiscal_company_base branch August 5, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants