Fail to parse empty field lists for Object, Interface, and Input Object types #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per the spec, [Object][1], [Interface][2], and [Input Object][3] types must define at least one field. This commit makes graphql-go fail to parse any of these types if no fields are defined. [1]: http://facebook.github.io/graphql/October2016/#sec-Object-type-validation [2]: http://facebook.github.io/graphql/October2016/#sec-Interface-type-validation [3]: http://facebook.github.io/graphql/October2016/#sec-Input-Object-type-validation
|
Thanks! I think this PR has to, actually, be split into 2 PRs. One for refactoring and another one to add validation for these types. This would make it much cleaner and would increase the chances of getting it merged. There are also conflicts to be resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the spec, Object, Interface, and Input Object types must define at least one field. This commit makes graphql-go fail to parse any of these types if no fields are defined.
The first three commits are some refactors that I thought may help with clarity. Only the last makes any observable behavior change.
Let me know what you think!