Properly handle nil interface resolvers #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Can we add a test case for this? |
|
Hello- We've ran into this issue on our local server. What kind of test case would be appropriate in order to merge this fix? |
|
I added a test case (as requested in #239 (comment)) in another PR based on this PR: wandb#1. @tonyghita If you'd like to merge this now, feel free to just cherry-pick my commit or whatever. Thanks! |
Prior to the fix, the new TestNilInterface test would fail with: graphql: panic occurred: reflect: Method on nil interface value
|
Thanks @sqs for fixing this up! @tonyghita is this good to merge now? |
pavelnikolov
requested changes
Oct 3, 2018
graphql_test.go
Outdated
| "testing" | ||
| "time" | ||
|
|
||
| "github.com/graph-gophers/graphql-go" | ||
| graphqlerrors "github.com/graph-gophers/graphql-go/errors" |
There was a problem hiding this comment.
Can you, please, rename this graphqlerrors -> gqlerrors to be shorter and to be consistent with gqltesting?
pavelnikolov
reviewed
Oct 8, 2018
pavelnikolov
approved these changes
Oct 8, 2018
|
Thank you for your contribution! |
tinnywang
pushed a commit
to tinnywang/graphql-go
that referenced
this pull request
Dec 13, 2018
Properly handle nil interface resolvers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #233
Calling
reflect.ValueOf(nil)returns the zeroValue, which has typeInvalid.Calling
reflect.ValueOfan interface typed nil returns aValuewith typeInterface.Both of these cases skipped the null checks and fail later on when trying to resolve fields.