-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #299: unclear error message in case of multiline string argument #412
Conversation
Excuse me, can anyone give a hint what could be the difference between local test run and semaphoreci? Local run passes ok:
Semaphoreci failes (part of the returned error string after "See near..." is missing):
Thank you! |
Tests are OK now The only difference I've noticed is that SemaphoreCI runs on go 1.11 by default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Can you, please fix the empty lines and I'd be happy to merge this PR.
Fix #299
Package text/scanner, which is used to parse queries, already detects multiline strings as an error. But it only puts log message to console, as it was pointed in the issue description. Scanner can also call a function each time it encounters error
So the idea of the fix is: