@graph-paper/stack: use owl selectors to allow smooth slide in/out transitions instead of grid-column-gap #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openjck
referenced
this pull request
in openjck/graph-paper
Jul 7, 2020
See the discussion in #56 for more information.
…S reset stylesheet first, since it would be good to have * { margin: 0px; } among other rules. This decision actually blocks this PR since we have an issue with explicitly-set 0-margin Button elements not adhering to the stack margin rule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #35
Re-implements the
Stackcomponent to use an owl selector instead ofgrid-column-gap. The stack itself, however, is sitll implemented in CSS grid, giving flexibiilty w/ the same the justify / align props. This allows the spacing to be collapsed in various ways when transitioning in a new element. See theColorPalette.sveltestory as an example.Practically speaking, this should have no visual effect for end users.