Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xtext 2.30 #47

Merged
merged 9 commits into from
Apr 13, 2023
Merged

Xtext 2.30 #47

merged 9 commits into from
Apr 13, 2023

Conversation

ashpak-shaikh
Copy link
Contributor

What Changed

Xtext 2.30

Why

Upgrades are good

@ashpak-shaikh
Copy link
Contributor Author

#22

@@ -2,14 +2,14 @@ Manifest-Version: 1.0
Automatic-Module-Name: com.intuit.graphql.ide
Bundle-ManifestVersion: 2
Bundle-Name: com.intuit.graphql.ide
Bundle-Vendor: Intuit
Bundle-Vendor: My Company
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be Intuit?

@@ -2,14 +2,15 @@ Manifest-Version: 1.0
Automatic-Module-Name: com.intuit.graphql.tests
Bundle-ManifestVersion: 2
Bundle-Name: com.intuit.graphql.tests
Bundle-Vendor: Intuit
Bundle-Vendor: My Company
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intuit?

@@ -2,17 +2,18 @@ Manifest-Version: 1.0
Automatic-Module-Name: com.intuit.graphql.ui.tests
Bundle-ManifestVersion: 2
Bundle-Name: com.intuit.graphql.ui.tests
Bundle-Vendor: Intuit
Bundle-Vendor: My Company
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intuit?

@@ -2,19 +2,19 @@ Manifest-Version: 1.0
Automatic-Module-Name: com.intuit.graphql
Bundle-ManifestVersion: 2
Bundle-Name: com.intuit.graphql
Bundle-Vendor: Intuit
Bundle-Vendor: My Company
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intuit?

bhavinshah7
bhavinshah7 previously approved these changes Mar 14, 2023
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file not needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be needed. good catch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants