#873 - Fixing rating crash

graphefruit · Jan 5, 2025 · d8840c6 · d8840c6
1 parent e06f963
commit d8840c6
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/app/settings/settings.page.html b/src/app/settings/settings.page.html
@@ -161,7 +161,7 @@ <h2>{{"PAGE_SETTINGS_BREW_RATING" | translate}}</h2>
           </ion-item>
           <ion-item style="top:-10px;" lines="none">
             <ion-range [disabled]='isScrolling' style="padding-left:20px;padding-top:0;padding-bottom:15px;padding-right:0px;" min="5" snaps="true" max="100"
-              step="1" (ngModelChange)="changeBrewRating()" [(ngModel)]="settings.brew_rating">
+              step="1" (ngModelChange)="changeBrewRating()" (ionBlur)="changedBrewRatingBlur()" [(ngModel)]="settings.brew_rating">
               <div class='ion-label' slot="end">{{settings.brew_rating}}</div>
             </ion-range>
 
@@ -196,7 +196,7 @@ <h2>{{"PAGE_SETTINGS_BEAN_RATING" | translate}}</h2>
           </ion-item>
           <ion-item style="top:-10px;" lines="none">
             <ion-range [disabled]='isScrolling' style="padding-left:20px;padding-top:0;padding-bottom:15px;padding-right:0px;" min="5" snaps="true" max="100"
-              step="1" (ngModelChange)="changeBeanRating()" [(ngModel)]="settings.bean_rating">
+              step="1" (ngModelChange)="changeBeanRating()" (ionBlur)="changeBeanRatingBlur()" [(ngModel)]="settings.bean_rating">
               <div class='ion-label' slot="end">{{settings.bean_rating}}</div>
             </ion-range>
 

diff --git a/src/app/settings/settings.page.ts b/src/app/settings/settings.page.ts
@@ -405,6 +405,9 @@ export class SettingsPage {
     // #379 - First save then reset filter ;)
     await this.saveSettings();
     this.settings.resetFilter();
+  }
+
+  public async changedBrewRatingBlur() {
     setTimeout(() => {
       const newRating = this.settings.brew_rating;
 
@@ -424,6 +427,9 @@ export class SettingsPage {
   public async changeBeanRating() {
     await this.saveSettings();
     this.settings.resetFilter();
+  }
+
+  public async changeBeanRatingBlur() {
     setTimeout(() => {
       const newRating = this.settings.bean_rating;