-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/forbidden flags #128
Feat/forbidden flags #128
Conversation
} | ||
|
||
flagsToSkip = await forbiddenFlagsResult; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
} | |
flagsToSkip = await forbiddenFlagsResult; | |
} else { | |
flagsToSkip = await forbiddenFlagsResult; | |
} |
Could it be that it's actually PostgreSQL 9.6 kicking out the syntax somewhere? The PR's a little too large for me to quickly scan it and spot the issue.
I really need to track a version of the PostgreSQL schema in version control so I can track the actual diff. (I don't have time to fully review this today, but if we can get this and #129 approved I'll merge them into a single migration manually later.) |
I don't have write permission to this branch; please merge my changes from this branch: https://github.com/graphile/worker/tree/feat/forbidden-flags (I merged the latest |
I've pushed a huge chunk more work to feat/forbidden-flags |
The syntax error was indeed a PG9.6 issue; |
(More work on the other branch.) |
Closing in favor of #131 |
This implements forbidden flags as per #118.
As far as I can tell by running and rerunning the perfTest at various stages of development and at the end, this has no impact on performance for users who choose not to use the feature.
Right now, 14.9.6 is failing with a Postgresql syntax error - do you know if there is something funky with
pg
going on in that version?