Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typos #316

Merged
merged 2 commits into from
May 4, 2023
Merged

docs: fix typos #316

merged 2 commits into from
May 4, 2023

Conversation

Lioness100
Copy link
Contributor

Description

Fixed 2 random typos (this was a trial run for a CLI I made)

Performance impact

unknown

Security impact

unknown

Checklist

  • My code matches the project's code style and yarn lint:fix passes.
  • I've added tests for the new feature, and yarn test passes.
  • I have detailed the new feature in the relevant documentation.
  • I have added this feature to 'Pending' in the RELEASE_NOTES.md file (if one exists).
  • If this is a breaking change I've explained why.

benjie
benjie previously approved these changes Feb 12, 2023
Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@benjie
Copy link
Member

benjie commented Feb 12, 2023

The word wrapping will have changed in the release notes, prettier needs to run.

@Lioness100
Copy link
Contributor Author

yarn lint:fix responds "Invalid option '--write' - perhaps you meant '--rule'?". Removing --write, yarn lint:fix replies "No files matching the pattern "prettier" were found.". yarn lint responds [error] "No files matching the pattern were found: "'**/*.{js,jsx,ts,tsx,graphql,md,json}'"". I'm on Windows.

@benjie
Copy link
Member

benjie commented Feb 13, 2023

Ah on windows you can’t have single quotes in shell args. Not sure about—write though, works for me and is documented. Thanks for trying.

https://prettier.io/docs/en/cli.html

Oh, again it’s the semicolon which doesn’t work for Windows.

RELEASE_NOTES.md Outdated Show resolved Hide resolved
@benjie benjie merged commit b3c1bac into graphile:main May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants