Skip to content

Conversation

DataBoyTX
Copy link
Contributor

@DataBoyTX DataBoyTX commented Jun 10, 2025

  1. change all docker-compose refs to docker compose

  2. update python versions for CI from 3.7-3.9 to 3.10-3.13

@DataBoyTX DataBoyTX requested a review from aucahuasi June 10, 2025 04:31
Copy link
Contributor

@lmeyerov lmeyerov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, well overdue

See comments, I think we need to:

  • Drop the compose installer / linker
  • Not edit file names like docker-compose.yml, just the commands

@DataBoyTX
Copy link
Contributor Author

Thanks, well overdue

See comments, I think we need to:

  • Drop the compose installer / linker
  • Not edit file names like docker-compose.yml, just the commands

@lmeyerov: I confirmed by running a simple test that the amazon linux docker does not have the docker plugin, so we can either stick with docker-compose install as-is, or install from the official docker repo to get the latest w/ plugin. Let me know which path is preferred.

@lmeyerov
Copy link
Contributor

What i mean is we don't need to do the extra aliasing step of linking of bin/docker-compose to some install

I'm unsure if install docker installs 'docker compose' or we need to tell it explicitly as part of that - I think installing docker gets you compose too, so we can skip the explicit download of compose as well, if a modern docker

graphistry and Louie host scripts are probably good refs of how to do, guessing these are OSS'd variants of those

@DataBoyTX
Copy link
Contributor Author

What i mean is we don't need to do the extra aliasing step of linking of bin/docker-compose to some install

I'm unsure if install docker installs 'docker compose' or we need to tell it explicitly as part of that - I think installing docker gets you compose too, so we can skip the explicit download of compose as well, if a modern docker

graphistry and Louie host scripts are probably good refs of how to do, guessing these are OSS'd variants of those

I tried several variations to get it work, but I don't think it's possible on AL2. Amazon Linux 2 EOL was extended to June 2026, so we might want to consider moving to version 3 now, otherwise we'll likely be revisiting this PR a year from now.

@DataBoyTX DataBoyTX changed the title fix: change all docker-compose refs to docker compose fix: change all docker-compose refs to docker compose and update python versions for CI Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants