-
Notifications
You must be signed in to change notification settings - Fork 25
fix: change all docker-compose refs to docker compose and update python versions for CI #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, well overdue
See comments, I think we need to:
- Drop the compose installer / linker
- Not edit file names like docker-compose.yml, just the commands
@lmeyerov: I confirmed by running a simple test that the amazon linux docker does not have the docker plugin, so we can either stick with docker-compose install as-is, or install from the official docker repo to get the latest w/ plugin. Let me know which path is preferred. |
What i mean is we don't need to do the extra aliasing step of linking of bin/docker-compose to some install I'm unsure if install docker installs 'docker compose' or we need to tell it explicitly as part of that - I think installing docker gets you compose too, so we can skip the explicit download of compose as well, if a modern docker graphistry and Louie host scripts are probably good refs of how to do, guessing these are OSS'd variants of those |
I tried several variations to get it work, but I don't think it's possible on AL2. Amazon Linux 2 EOL was extended to June 2026, so we might want to consider moving to version 3 now, otherwise we'll likely be revisiting this PR a year from now. |
change all
docker-compose
refs todocker compose
update python versions for CI from
3.7-3.9
to3.10-3.13