-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow special characters in target names to be escaped #242
Labels
Milestone
Comments
This was referenced Mar 14, 2013
what about file system paths? like "/usr/local"? You cannot escape "/" in file path |
👍 |
This was referenced Jan 24, 2016
deniszh
added a commit
that referenced
this issue
Oct 23, 2019
…pr-2425_pr-2426_pr-2426_pr-2426_pr-2431_pr-2433_pr-2436_pr-2436_pr-2443_commit-91ed1c0b_pr-2450_pr-2450_pr-2451_pr-2452_pr-2452_pr-2462_pr-2462_pr-2463_pr-2464_pr-2464_pr-2466_pr-2467_ [1.1.x] set package long description (#2407) | fix dashboard graph metric list icon paths with URL_PREFIX (#2424) | docs: for sql db migration to 1.1 recommend --fake-initial (#2425) | add tag formatting docs (#2426) | Update tags.rst (#242
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I think this is primarily a change to the pyparsing grammar for targets (https://github.com/graphite-project/graphite-web/blob/master/webapp/graphite/render/grammar.py).
Though the browse tree code should also know how to deal with a target name like this properly once a fix is in place in the rendering code.
#120 is an option as well, but I feel like url encoding doesnt really belong that far down from the view code. Instead, I think we can solve it by starting to treat the targets more as we would other grammars and just 'backslash it out'
e.g. a metric named
would be added as:
The text was updated successfully, but these errors were encountered: