remove leading ~ from name when indexing metric names

[replay]

No description provided.

[DanCech]

This doesn't match the actual implementation in the TaggedSeries class, which will reject tagged series with ~ in the value.

[DanCech]

We want to keep TaggedSeries the same between graphite-web and carbon (ideally we'd break it out into a separate graphite-util package but if we're going to move toward a go implementation of carbon it doesn't make sense to put in the work required to do that vs just keeping the class in sync across the repos). If you can sync them up that would be great, I'd also suggest that the sanitize function should use https://docs.python.org/2/library/string.html#string.lstrip vs replace.

[codecov-io]

Codecov Report

Merging #2458 into master will decrease coverage by 0.91%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master    #2458      +/-   ##
==========================================
- Coverage   80.05%   79.13%   -0.92%     
==========================================
  Files          85       85              
  Lines        8948     9150     +202     
  Branches     1914     1948      +34     
==========================================
+ Hits         7163     7241      +78     
- Misses       1511     1630     +119     
- Partials      274      279       +5

Impacted Files	Coverage Δ
webapp/graphite/tags/redis.py	90.74% <50%> (-1.09%)	⬇️
webapp/graphite/tags/utils.py	79.74% <50%> (+0.33%)	⬆️
webapp/graphite/tags/localdatabase.py	93.66% <50%> (-0.71%)	⬇️
webapp/graphite/tags/base.py	91.79% <50%> (-2.66%)	⬇️
webapp/graphite/tags/http.py	94.8% <50%> (-5.2%)	⬇️
webapp/graphite/middleware.py	77.77% <0%> (-22.23%)	⬇️
webapp/graphite/render/evaluator.py	90.34% <0%> (-9.66%)	⬇️
webapp/graphite/url_shortener/views.py	42.85% <0%> (-9.53%)	⬇️
webapp/graphite/functions/params.py	90.54% <0%> (-9.46%)	⬇️
webapp/graphite/util.py	81.66% <0%> (-9.17%)	⬇️
... and 28 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a103fa...9f67047. Read the comment docs.

[replay]

I'd also suggest that the sanitize function should use https://docs.python.org/2/library/string.html#string.lstrip vs replace

I'm not sure which sanitize function you mean, the one in the carbon project, right? If so, then I've already updated that to use .lstrip in https://github.com/graphite-project/carbon/pull/858/files
Or do you think that graphite should also sanitize the values when it receives a request to tag a series? So far graphite is only validating, but not sanitizing. Carbon is doing the sanitizing.

[replay]

I didn't realize that the TaggedSeries class in carbon and graphite is pretty much the same, i'll sync the carbon one to graphite then

[replay]

I've pushed a few more tests, so the test coverage report is happy

[replay]

Rebased onto the latest master