Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update grafana dashboard #163

Merged
merged 2 commits into from
Oct 30, 2024
Merged

fix: Update grafana dashboard #163

merged 2 commits into from
Oct 30, 2024

Conversation

i0n
Copy link
Contributor

@i0n i0n commented Oct 29, 2024

Description

Display data from Arbitrum-One and Arbitrum-Sepolia deployments using yesoreyeram-infinity-datasource plugin

Checklist

PR to update docs:
graphops/docs#101

grafana.json Outdated
Comment on lines 1241 to 938
"version": 17,
"version": 6,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the dashboard version is going backwards and am not 100% if this has any impact. I suspect it won't impact anyone deploying the dashboard via our usual manner as the "original" vanishes from the configmap and gets replaced, but maybe it impacts anyone importing this dashboard some different way - no idea.

Anyone knows if this matters at all?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m not sure if this is relevant either but I’ve bumped to 18 just in case.

i0n added 2 commits October 30, 2024 11:18
@i0n i0n force-pushed the fix/update-grafana-dashboard branch from 037334f to a0fe4d0 Compare October 30, 2024 11:18
@i0n i0n merged commit 5bc2096 into dev Oct 30, 2024
1 check passed
@i0n i0n deleted the fix/update-grafana-dashboard branch October 30, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants