Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove edge cloning alias methods, use Graph instead #177

Merged
merged 1 commit into from
Oct 5, 2019

Conversation

clue
Copy link
Member

@clue clue commented Oct 5, 2019

// old (removed alias methods)
$new = $edge->createEdgeClone();
$inverted = $edge->createEdgeCloneInverted();

// new (already supported before)
$new = $graph->createEdgeClone($edge);
$inverted = $graph->createEdgeCloneInverted($edge);

// old (rarely used)
$walkGraph = $walk->createGraph();

// new (already supported before)
$walkGraph = $graph
    ->createGraphCloneEdges($walk->getEdges())
    ->createGraphCloneVertices($walk->getVertices());

Builds on top of #175

@clue clue added the BC break label Oct 5, 2019
@clue clue added this to the v1.0.0 milestone Oct 5, 2019
@clue clue merged commit d71768d into graphp:master Oct 5, 2019
@clue clue deleted the createalias branch October 5, 2019 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant