Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new Entity class to simplify holding attributes and remove attribute namespace #187

Merged
merged 1 commit into from
Jan 5, 2020
Merged

Add new Entity class to simplify holding attributes and remove attribute namespace #187

merged 1 commit into from
Jan 5, 2020

Conversation

clue
Copy link
Member

@clue clue commented Jan 5, 2020 

// old
assert($graph instanceof \Graphp\Graph\Attribute\AttributeAware);
assert(is_array($graph->getAttributesBag()->getAttributes()));

// new (applies to Graph, Vertex and Edge)
assert($graph instanceof \Graphp\Graph\Entity);
assert(is_array($graph->getAttributes()));

Builds on top of #182, #185 and 186

@clue clue added this to the v1.0.0 milestone Jan 5, 2020
@clue clue merged commit 81eef65 into graphp:master Jan 5, 2020
@clue clue deleted the entity branch January 5, 2020 18:27
clue added a commit to clue-labs/graphviz that referenced this pull request Jan 8, 2020
@clue
Inline filtering prefixed attributes
8d85d84 
Refs graphp/graph#187
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
BC break new feature
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@clue