Remove all custom Exception classes, use built-in Exceptions instead #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llaville
added a commit
to llaville/graph-uml
that referenced
this pull request
Sep 10, 2020
clue
added a commit
to clue-labs/graphviz
that referenced
this pull request
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all custom Exception classes, use built-in Exceptions instead. For instance, instead of throwing an
Graphp\Graph\Exception\InvalidArgumentException, a method will now throw anInvalidArgumentException. The custom Exception classes did not provide any functionality over the built-in Exception classes and in fact already implemented the built-in ones, so the BC impact should be limited.The
Graphp\Graph\Exception\NegativeCycleExceptionis the only Exception class that used to provide any functionality. However, this is better off in the graphp/algorithms package instead as per #119.