Skip to content

fix: use solidity division instead of fixed point scaling (OZ L-04) #1136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: horizon-oz2/l05-provision-params
Choose a base branch
from
Open

fix: use solidity division instead of fixed point scaling (OZ L-04) #1136

wants to merge 1 commit into from

Conversation

tmigone
Copy link
Member

@tmigone tmigone commented Mar 27, 2025

Signed-off-by: Tomás Migone tomas@edgeandnode.com

@tmigone tmigone force-pushed the horizon-oz2/l04-fixed-point-precision branch from c163ec4 to b52befb Compare March 27, 2025 16:33
@tmigone tmigone changed the title fix: only check conditions for param that is changing when changing provision params (OZ L-05) fix: use solidity division instead of fixed point scaling (OZ L-04) Mar 27, 2025
@tmigone tmigone requested review from Maikol and pcarranzav March 27, 2025 16:34
@tmigone tmigone added bug Something isn't working horizon solidity audit-fix and removed bug Something isn't working labels Mar 27, 2025
@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Mar 27, 2025 •
edited
Loading

fix: use solidity division instead of fixed point scaling (OZ L-04)

Generated at commit: 37faf784a9b0e5741763f3af3cc20b2d8f3ae2ab

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 2
4
0
15
38
59
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@tmigone tmigone force-pushed the horizon-oz2/l05-provision-params branch from 2787a52 to 4df5ec0 Compare April 23, 2025 14:10
@tmigone tmigone force-pushed the horizon-oz2/l04-fixed-point-precision branch from b52befb to 4730ed9 Compare April 23, 2025 20:37
@tmigone tmigone force-pushed the horizon-oz2/l05-provision-params branch from 4df5ec0 to 40c9a28 Compare May 2, 2025 15:11
@tmigone
fix: use solidity division instead of fixed point scaling (OZ L-04)
37faf78 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone tmigone force-pushed the horizon-oz2/l04-fixed-point-precision branch from 4730ed9 to 37faf78 Compare May 2, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcarranzav pcarranzav pcarranzav approved these changes

@Maikol Maikol Maikol approved these changes

Assignees
No one assigned
Labels
audit-fix horizon solidity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tmigone @pcarranzav @Maikol