Skip to content

chore: update incorrect comments (OZ N-10) #1156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: horizon-oz2/n09-var-shadowing
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ abstract contract DataServiceFees is DataService, DataServiceFeesV1Storage, IDat
* @dev This function is used as a callback in the stake claims linked list traversal.
* @param _claimId The id of the stake claim
* @param _acc The accumulator for the stake claims being processed
* @return Wether the stake claim is still locked, indicating that the traversal should continue or stop.
* @return Whether the stake claim is still locked, indicating that the traversal should continue or stop.
* @return The updated accumulator data
*/
function _processStakeClaim(bytes32 _claimId, bytes memory _acc) private returns (bool, bytes memory) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -153,8 +153,6 @@ abstract contract ProvisionManager is Initializable, GraphDirectory, ProvisionMa
* the {HorizonStaking} contract.
* @dev Checks the pending provision parameters, not the current ones.
*
* Emits a {ProvisionPendingParametersAccepted} event.
*
* @param _serviceProvider The address of the service provider.
*/
function _acceptProvisionParameters(address _serviceProvider) internal {
Expand Down
5 changes: 3 additions & 2 deletions packages/horizon/contracts/interfaces/IAuthorizable.sol
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ interface IAuthorizable {
* - `proof` must be a valid signature from the signer being authorized
*
* Emits a {SignerAuthorized} event
* @param signer The addres of the signer
* @param signer The address of the signer
* @param proofDeadline The deadline for the proof provided by the signer
* @param proof The proof provided by the signer to be authorized by the authorizer
* consists of (chain id, verifying contract address, domain, proof deadline, authorizer address)
Expand Down Expand Up @@ -141,7 +141,8 @@ interface IAuthorizable {
function revokeAuthorizedSigner(address signer) external;

/**
* @notice Returns the timestamp at which the thawing period ends for a signer
* @notice Returns the timestamp at which the thawing period ends for a signer.
* Returns 0 if the signer is not thawing.
* @param signer The address of the signer
* @return The timestamp at which the thawing period ends
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ interface IHorizonStakingMain {
/**
* @notice Emitted when a service provider unstakes tokens during the transition period.
* @param serviceProvider The address of the service provider
* @param tokens The amount of tokens unstaked
* @param tokens The amount of tokens now locked (including previously locked tokens)
* @param until The block number until the stake is locked
*/
event HorizonStakeLocked(address indexed serviceProvider, uint256 tokens, uint256 until);
Expand Down
2 changes: 1 addition & 1 deletion packages/horizon/contracts/libraries/MathUtils.sol
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ library MathUtils {
* @dev Calculates the weighted average of two values pondering each of these
* values based on configured weights. The contribution of each value N is
* weightN/(weightA + weightB). The calculation rounds up to ensure the result
* is always greater than the smallest of the two values.
* is always equal or greater than the smallest of the two values.
* @param valueA The amount for value A
* @param weightA The weight to use for value A
* @param valueB The amount for value B
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ contract GraphTallyCollector is EIP712, GraphDirectory, Authorizable, IGraphTall
* This variant adds the ability to partially collect a RAV by specifying the amount of tokens to collect.
* @param _paymentType The payment type to collect
* @param _data Additional data required for the payment collection
* @param _tokensToCollect The amount of tokens to collect
* @param _tokensToCollect The amount of tokens to collect. If 0, all tokens from the RAV will be collected.
* @return The amount of tokens collected
*/
function _collect(
Expand Down
2 changes: 1 addition & 1 deletion packages/subgraph-service/contracts/DisputeManager.sol
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ contract DisputeManager is
)
);

// Only one dispute for a (indexer, subgraphDeploymentId) at a time
// Only one dispute at a time
require(!isDisputeCreated(disputeId), DisputeManagerDisputeAlreadyCreated(disputeId));

// Store dispute
Expand Down