Add dev container config to Horizon #1181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR adds a dev container configuration to the Horizon branch to simplify development setup for Graph Protocol contracts by incorporating updated settings based on the main branch and switching dependency management to pnpm.
- Introduces new scripts (project-setup.sh, host-setup.sh, setup-git-signing.sh) to configure both the container and host environments.
- Updates configuration files (docker-compose.yml, devcontainer.json, Dockerfile, README.md, sample-graph.env) to support the new development workflow.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .devcontainer/setup-git-signing.sh | Script to set up Git SSH signing using forwarded SSH keys |
| .devcontainer/sample-graph.env | Sample environment file outlining Git commit signing and custom binary path settings |
| .devcontainer/project-setup.sh | Script to perform project-specific setup including dependency installation with pnpm |
| .devcontainer/host-setup.sh | Script to initialize host directories for caching and environmental preparation |
| .devcontainer/docker-compose.yml | Defines the dev container service configurations including environment variables and volume mounts |
| .devcontainer/devcontainer.json | Dev container configuration file that uses docker-compose and specifies extensions for VS Code |
| .devcontainer/README.md | Documentation providing an overview and setup instructions for the dev container |
| .devcontainer/Dockerfile | Dockerfile setting up the base image with dependencies, tools, and PNPM configuration |
|
I'm going to merge this, all files are in .devcontainer dir and should not impact anything else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not urgent but would be convenient to have this on horizon branch.
Based on main dev container config and updated to use pnpm instead of yarn.