staking: check caller is the channel proxy when settling #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Most of the changes in disputes.js seems to be prettier. |
abarmat
force-pushed
the
ariel/staking-tests-1
branch
2 times, most recently
from
c309d50 to
f2140ad
Compare
abarmat
force-pushed
the
ariel/staking-check-caller
branch
from
fa80fb3 to
9e815dc
Compare
|
Rebased |
davekaj
approved these changes
May 27, 2020
|
|
||
| // Receive funds from the channel multisig | ||
| // We use channelID to find the indexer owner of the channel | ||
| require(isChannel(_channelID), "Channel: does not exist"); | ||
| require(isChannel(channelID), "Channel: does not exist"); |
There was a problem hiding this comment.
this could be moved above the deletion of channelsProxy
There was a problem hiding this comment.
Will do and push the changes
abarmat
added a commit
that referenced
this pull request
May 28, 2020
* staking: advertise, in the AllocationCreated event, the non-binding price charged for queries related to an allocation * staking: check caller is the channel proxy when settling (#203)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
The
settle()function needs to be public so the multisig can call it.It means that it can be called by any party, and as the
channelIDis also public (advertised in allocate()) you could be settling a channel for someone else.Changes:
settle()that the caller is a channel proxy.channelIDfrom settle() and instead use the caller (proxy address) to find the allocation.Changes required in agents:
allocate(). Connext will provide a helper function to do this.