Allow unstake passing a larger amount than available #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davekaj
approved these changes
Jul 29, 2021
abarmat
force-pushed
the
ariel/unstake-all-margin
branch
from
71957c3 to
89efcdc
Compare
Codecov Report
@@ Coverage Diff @@
## dev #487 +/- ##
=======================================
Coverage 91.91% 91.91%
=======================================
Files 33 33
Lines 1658 1658
Branches 283 282 -1
=======================================
Hits 1524 1524
Misses 134 134
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Audited tag + fixes: https://github.com/graphprotocol/contracts/releases/tag/audit/pr-487 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When an indexer decides to unstake their stake completely there might be an opportunity to frontrun that operation through the
stakeTo()function, making unstake to fail with stake under minimum tokens.Solution
Allow
unstake()to accept a larger amount than the currently staked tokens. The function will try to unstake the passed amount capped to the available stake.