Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent unpausing gateways if they're not configured (OZ M-01 from #700) #733

Merged
merged 3 commits into from
Nov 10, 2022

Conversation

pcarranzav
Copy link
Member

Based on a finding from OZ's audit of #700, but targeting #699 as the change is relevant to that branch too.

@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Base: 91.53% // Head: 91.57% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (6d4a0d7) compared to base (323bdf8).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@                Coverage Diff                @@
##           pcv/l2-bridge     #733      +/-   ##
=================================================
+ Coverage          91.53%   91.57%   +0.04%     
=================================================
  Files                 42       42              
  Lines               1984     1995      +11     
  Branches             346      354       +8     
=================================================
+ Hits                1816     1827      +11     
  Misses               168      168              
Flag Coverage Δ
unittests 91.57% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
contracts/gateway/GraphTokenGateway.sol 100.00% <100.00%> (ø)
contracts/gateway/L1GraphTokenGateway.sol 100.00% <100.00%> (ø)
contracts/l2/gateway/L2GraphTokenGateway.sol 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

contracts/gateway/GraphTokenGateway.sol Show resolved Hide resolved
console.log('Done!')
})

task('migrate:unpause-bridge', 'Unpause bridge')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same change as https://github.com/graphprotocol/contracts/pull/717/files#diff-729e91d21c664fed317c8bccc772f1c5cce6a8a4d943d700359ad371302aef55

which is pending merge after audit. I'd still make the change here and later we solve the conflict whenever it shows up.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooh oops, sorry I missed that. But yeah, let's keep the change here so that we have e2e passing here.

@pcarranzav pcarranzav merged commit 6d4a0d7 into pcv/l2-bridge Nov 10, 2022
@pcarranzav pcarranzav deleted the pcv/700-699-m01-validation-before-unpause branch November 10, 2022 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants