-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prevent unpausing gateways if they're not configured (OZ M-01 from #700) #733
fix: prevent unpausing gateways if they're not configured (OZ M-01 from #700) #733
Conversation
Codecov ReportBase: 91.53% // Head: 91.57% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## pcv/l2-bridge #733 +/- ##
=================================================
+ Coverage 91.53% 91.57% +0.04%
=================================================
Files 42 42
Lines 1984 1995 +11
Branches 346 354 +8
=================================================
+ Hits 1816 1827 +11
Misses 168 168
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
console.log('Done!') | ||
}) | ||
|
||
task('migrate:unpause-bridge', 'Unpause bridge') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
which is pending merge after audit. I'd still make the change here and later we solve the conflict whenever it shows up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oooh oops, sorry I missed that. But yeah, let's keep the change here so that we have e2e passing here.
Based on a finding from OZ's audit of #700, but targeting #699 as the change is relevant to that branch too.