Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C4 QA fixes for #699 #743

Merged
merged 19 commits into from
Nov 23, 2022
Merged

C4 QA fixes for #699 #743

merged 19 commits into from
Nov 23, 2022

Conversation

@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Base: 91.58% // Head: 91.60% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (ce0d0a3) compared to base (e3a668e).
Patch coverage: 99.00% of modified lines in pull request are covered.

Additional details and impacted files
@@                Coverage Diff                 @@
##           tmigone/c4-gas     #743      +/-   ##
==================================================
+ Coverage           91.58%   91.60%   +0.01%     
==================================================
  Files                  42       42              
  Lines                1997     2000       +3     
  Branches              359      361       +2     
==================================================
+ Hits                 1829     1832       +3     
  Misses                168      168              
Flag Coverage Δ
unittests 91.60% <99.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
contracts/curation/Curation.sol 100.00% <ø> (ø)
contracts/gateway/BridgeEscrow.sol 100.00% <ø> (ø)
contracts/governance/Governed.sol 100.00% <ø> (ø)
contracts/governance/Pausable.sol 88.88% <ø> (ø)
contracts/l2/token/L2GraphToken.sol 100.00% <ø> (ø)
contracts/upgrades/GraphUpgradeable.sol 100.00% <ø> (ø)
contracts/upgrades/GraphProxyStorage.sol 90.00% <87.50%> (+0.52%) ⬆️
contracts/gateway/GraphTokenGateway.sol 100.00% <100.00%> (ø)
contracts/gateway/L1GraphTokenGateway.sol 100.00% <100.00%> (ø)
contracts/governance/Controller.sol 100.00% <100.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pcarranzav pcarranzav marked this pull request as ready for review October 24, 2022 21:44
@pcarranzav pcarranzav requested review from abarmat and tmigone October 24, 2022 22:00
contracts/curation/Curation.sol Show resolved Hide resolved
contracts/l2/gateway/L2GraphTokenGateway.sol Show resolved Hide resolved
contracts/l2/gateway/L2GraphTokenGateway.sol Outdated Show resolved Hide resolved
contracts/l2/gateway/L2GraphTokenGateway.sol Outdated Show resolved Hide resolved
Base automatically changed from tmigone/c4-gas to pcv/l2-bridge November 23, 2022 14:29
@pcarranzav pcarranzav merged commit ce0d0a3 into pcv/l2-bridge Nov 23, 2022
@pcarranzav pcarranzav deleted the pcv/c4-699-qa branch November 23, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants