Skip to content

Three Source Example #889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Mar 5, 2025
Merged

Three Source Example #889

merged 15 commits into from
Mar 5, 2025

Conversation

idalithb
Copy link
Contributor

@idalithb idalithb commented Feb 27, 2025 •
edited
Loading

  • Please review EN version of page ONLY
  • Adding another example for subgraph comp
  • Did not run any additional script, but page was added to all languages automatically

@benface
Copy link
Contributor

benface commented Feb 27, 2025 •
edited
Loading

Did not run any additional script, but page was added to all languages automatically

Wow @idalithb, I'm so sorry. You are completely right; the fix-pages-structure script (and the fetch-remote-docs one) were set to run every time you run dev, not just build like I thought/expected. That is my fault and I somehow never noticed. I fixed it here. Everything I said here should be true now (well, after you pull from main, so for the next changes you have to make). My sincere apologies! 🙇‍♂️

@benface benface mentioned this pull request Feb 27, 2025
Open
@idalithb idalithb requested a review from isum February 28, 2025 00:22
@idalithb idalithb marked this pull request as ready for review February 28, 2025 00:23
@idalithb idalithb requested a review from a team as a code owner February 28, 2025 00:23
MichaelMacaulay and others added 9 commits March 3, 2025 09:40
@MichaelMacaulay @benface
Update website/src/pages/en/subgraphs/cookbook/subgraph-composition-t…
04ccf09 
…hree-sources.mdx

Co-authored-by: Benoît Rouleau <benoit.rouleau@icloud.com>
@MichaelMacaulay @benface
Update website/src/pages/en/subgraphs/cookbook/subgraph-composition-t…
6a4a940 
…hree-sources.mdx

Co-authored-by: Benoît Rouleau <benoit.rouleau@icloud.com>
@MichaelMacaulay @benface
Update website/src/pages/en/subgraphs/cookbook/subgraph-composition-t…
332e1f1 
…hree-sources.mdx

Co-authored-by: Benoît Rouleau <benoit.rouleau@icloud.com>
@MichaelMacaulay @benface
Update website/src/pages/en/subgraphs/cookbook/subgraph-composition-t…
886474c 
…hree-sources.mdx

Co-authored-by: Benoît Rouleau <benoit.rouleau@icloud.com>
@MichaelMacaulay @benface
Update website/src/pages/en/subgraphs/cookbook/subgraph-composition-t…
1b83f28 
…hree-sources.mdx

Co-authored-by: Benoît Rouleau <benoit.rouleau@icloud.com>
@MichaelMacaulay @benface
Update website/src/pages/en/subgraphs/cookbook/subgraph-composition-t…
87c9d08 
…hree-sources.mdx

Co-authored-by: Benoît Rouleau <benoit.rouleau@icloud.com>
@MichaelMacaulay @benface
Update website/src/pages/en/subgraphs/cookbook/subgraph-composition-t…
0d03bd4 
…hree-sources.mdx

Co-authored-by: Benoît Rouleau <benoit.rouleau@icloud.com>
@MichaelMacaulay @benface
Update website/src/pages/en/subgraphs/cookbook/subgraph-composition-t…
28979b1 
…hree-sources.mdx

Co-authored-by: Benoît Rouleau <benoit.rouleau@icloud.com>
@MichaelMacaulay
Final feedback
d5cd007
benface
benface approved these changes Mar 3, 2025
View reviewed changes
Copy link
Contributor

@benface benface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some nitpicks. LGTM

@MichaelMacaulay MichaelMacaulay merged commit 6d9362f into main Mar 5, 2025
1 of 3 checks passed
@MichaelMacaulay MichaelMacaulay deleted the source-example branch March 5, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benface benface benface approved these changes

@isum isum Awaiting requested review from isum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@idalithb @benface @MichaelMacaulay