fix: make indexer errors attestable when is enabled

graphprotocol · Aug 19, 2024 · c8025ac · c8025ac
1 parent e2e6925
commit c8025ac
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/graph/src/data/query/error.rs b/graph/src/data/query/error.rs
@@ -9,7 +9,7 @@ use std::sync::Arc;
 
 use crate::data::subgraph::*;
 use crate::prelude::q;
-use crate::{components::store::StoreError, prelude::CacheWeight};
+use crate::{components::store::StoreError, prelude::CacheWeight, schema::ErrorPolicy};
 
 #[derive(Debug, Clone)]
 pub struct CloneableAnyhowError(Arc<anyhow::Error>);
@@ -350,15 +350,23 @@ pub enum QueryError {
  EncodingError(FromUtf8Error),
  ParseError(Arc<anyhow::Error>),
  ExecutionError(QueryExecutionError),
- IndexingError,
+ IndexingError { subgraph_error_allowed: bool },
 }
 
 impl QueryError {
  pub fn is_attestable(&self) -> bool {
  match self {
  QueryError::EncodingError(_) | QueryError::ParseError(_) => true,
  QueryError::ExecutionError(err) => err.is_attestable(),
- QueryError::IndexingError => false,
+ QueryError::IndexingError {
+ subgraph_error_allowed,
+ } => *subgraph_error_allowed || false,
+ }
+ }
+
+ pub fn indexer_error_with_policy(policy: ErrorPolicy) -> Self {
+ QueryError::IndexingError {
+ subgraph_error_allowed: matches!(policy, ErrorPolicy::Allow),
  }
  }
 }

diff --git a/graphql/src/store/resolver.rs b/graphql/src/store/resolver.rs
@@ -404,7 +404,7 @@ impl Resolver for StoreResolver {
 
  // Add the "indexing_error" to the response.
  assert!(result.errors_mut().is_empty());
- *result.errors_mut() = vec![QueryError::IndexingError];
+ *result.errors_mut() = vec![QueryError::indexer_error_with_policy(self.error_policy)];
 
  match self.error_policy {
  // If indexing errors are denied, we omit results, except for the `_meta` response.