GraphQL: indexing_error should only be returned if the subgraph has non-fatal errors feature enabled

[evaporei]

An example was brought up by @itsjerryokolo with this subgraph https://thegraph.com/hosted-service/subgraph/astox/main, where it was synced up to chain head, but the errors wouldn't display in the playground, even with the subgraphError: allow.

This function is incomplete as described by @leoyvens

graph-node/store/postgres/src/deployment.rs

Line 663 in a74a37e

pub(crate) fn has_non_fatal_errors(

, it returns true even if the subgraph doesn't use the non-fatal errors feature enabled.

[leoyvens]

Actually we should return indexing_error for a subgraph failed with a deterministic error, even if non-fatal errors is disabled. So maybe the code is already behaving as expected, and the function just needs to be renamed and clarified.

[azf20]

@leoyvens in that case is this about renaming, rather than a functionality issue?

[leoyvens]

Yes at this point this is just tracking the refactor in #3662.