Two simple config changes #4133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoyvens
approved these changes
Nov 4, 2022
lutter
force-pushed
the
lutter/disable
branch
from
a3aca7c
to
7d8adb2
Compare
GRAPH_DISABLE_ERROR_FOR_TOPLEVEL_PARENTS was added as a safety mechanism, but never needed.
Also lower the default to 3 minutes; 5 minutes is too much on busy systems
lutter
force-pushed
the
lutter/disable
branch
from
7d8adb2
to
e763c93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only the second one, making the target duration for batch operations configurable, is somewhat interesting