Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store(test-store): use C locale for DB #4340

Merged
merged 1 commit into from
Feb 6, 2023
Merged

store(test-store): use C locale for DB #4340

merged 1 commit into from
Feb 6, 2023

Conversation

saihaj
Copy link
Member

@saihaj saihaj commented Feb 6, 2023

while working on tests for #3214 I had to make this change. But useful to just land it upstream since it is unrelated to that PR

lutter
lutter approved these changes Feb 6, 2023
View reviewed changes
Copy link
Collaborator

@lutter lutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find. Yes, that's definitely needed

@saihaj saihaj merged commit 2ca18d5 into master Feb 6, 2023
@saihaj saihaj deleted the saihaj/minor-devx-imrpv branch February 6, 2023 21:06
@jaybuidl jaybuidl mentioned this pull request Apr 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lutter lutter lutter approved these changes

@dotansimha dotansimha Awaiting requested review from dotansimha

@leoyvens leoyvens Awaiting requested review from leoyvens

@neysofu neysofu Awaiting requested review from neysofu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saihaj @lutter