Restructure integration tests to make rust-analyzer happy #4510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- check that the writer thread is still running when accepting items to be queued. It makes no sense to accept requests when the writer thread is not running, and should therefore fail early. - change the mechanism for how tests can single-step a deployment to be specific to that deployment to avoid problems with tests running at the same time. This was a huge footgun, and getting caught in that looks like a deadlock - implement Debug for queued requests
leoyvens
approved these changes
Apr 10, 2023
That one was actually necessary (and the hardest part of this PR) since all the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the cyclic dev-dependencies that make rust-analyzer almost useless by moving integration tests from their individual crates into the
test-storecrate. It's a little weird to have the tests outside their crates, but almost all integration tests really do need the whole system directly or indirectly.Given a choice between a little weirdness with test placement and a rust-analyzer that by now is basically unable to find anything, I'd rather live with the weirdness.