Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONTRIBUTING.md: Updating deprecated rustfmt-preview #4645

Merged

Conversation

jtfirek
Copy link
Contributor

@jtfirek jtfirek commented May 25, 2023

Rust has deprecated the rustfmt-preview with the rustfmt component. rustup understands that rustfmt-preview is now just rustfmt and checks for that instead, but we could still just update this to the new command.

Second, this is a preview, as it says in the name. rustfmt is not at 1.0 yet, and some stuff is being tweaked, and bugs are being fixed. Once rustfmt hits 1.0, we'll be releasing a rustfmt component and deprecating rustfmt-preview.

https://blog.rust-lang.org/2018/02/15/Rust-1.24.html

Copy link
Collaborator

@leoyvens leoyvens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@leoyvens leoyvens merged commit cb0471e into graphprotocol:master May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants