Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

substreams: Add support for overriding module params #4759

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

mangas
Copy link
Contributor

@mangas mangas commented Jul 17, 2023

If params is provided on the substreams-based subgraph manifest then replace all the existing params on the output module with the provided list.

FIxes #4577

@mangas mangas force-pushed the filipe/override-substreams-params branch from f01e47e to 0536ef5 Compare July 17, 2023 12:42
If params is provided on the substreams-based subgraph manifest
then replace all the existing params on the output module with the
provided list.
@mangas mangas force-pushed the filipe/override-substreams-params branch from 0536ef5 to b66b34e Compare July 17, 2023 12:45
Copy link
Member

@neysofu neysofu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good job with those tests 😁

@mangas mangas merged commit 399b732 into master Jul 17, 2023
@mangas mangas deleted the filipe/override-substreams-params branch July 17, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend substreams data source definition to pass params to parameterised substreams
2 participants